ui: remove legacy untested-model gaming prompt - #53
Merged
Conversation
mksolutionsuniversal
left a comment
mksolutionsuniversal
left a comment
Owner
Author
There was a problem hiding this comment.
Maintainer audit PASS.
Reviewed exact delta 3389f716c961e31bfb4996bc400214777b158878 -> d6be0b8f760b9f66371648f5e2c40e25addfbf0d.
Findings:
- exactly 1 commit, 6 changed files, +14/-110
- changes limited to CHANGELOG, UI composition/view-model, obsolete confirmation service removal, and focused UI tests
- no changes under FanControl, PowerManagement, Profiles, SettingsBackup, or drivers
- MainViewModel now enters the existing guarded apply path directly for
SupportedIntelMacregardless ofNotIndividuallyTested ModelValidationLevelreporting/display remains intact- focused test verifies one guarded processor apply, zero unguarded applies, expected 95/95 + Boost Disabled target, preserved original restore snapshot, and fan-only resume without CPU rewrite
- PerformanceValidated path remains guarded
- CI #178 on exact head: Gate 5D-B, Restore, Build, Test, and Validate release packaging all SUCCESS
No hardware-control behavior is modified by this PR. Ready to merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove the legacy per-model confirmation dialog before
Gaming OptimisedonSupportedIntelMacsystems.The global CPU policy is already the supported product policy for supported Intel Macs:
ModelValidationLevel.NotIndividuallyTestedremains visible in Overview, diagnostics and compatibility reporting, but no longer interrupts profile application with a modal confirmation.Scope
This is a release-candidate UX cleanup only.
IUserConfirmationService/WpfUserConfirmationServiceMainViewModel[Unreleased]changelog entryNo changes to:
Validation
Local validation reported on exact head
d6be0b8f760b9f66371648f5e2c40e25addfbf0d:644/644tests PASSgit diff --check: PASSpublish-release.ps1: PASSHardware qualification context
The underlying
0.5.0-rc.2product path was already physically validated onMacBookPro12,1before this UX-only change:GlobalMaskFpe2: Maximum Safe RPM reached and verifiedAfter merge, only a short UI smoke is required: no modal -> Gaming applies -> Restore returns Apple Auto.